Compare commits

...

2 Commits

Author SHA1 Message Date
HiGarfield
3dc19b7994
Merge ee1e4d33f8f01f8a53be3a726f922ad5eb6195aa into f49e6adedf8129df827c6ee11d8b3f8b456d28f6 2023-11-07 11:43:51 +08:00
HiGarfield
ee1e4d33f8 fix possible null pointer dereference
cppcheck reports:
network.cpp:1717:22: error: Null pointer dereference: payload [ctunullpointer]
    memcpy(tcp_data, payload, payloadlen);
                     ^
client.cpp:193:22: note: Calling function send_raw0, 2nd argument is null
            send_raw0(raw_info, 0, 0);
                     ^
network.cpp:2534:20: note: Calling function send_raw_tcp, 2nd argument is null
            return send_raw_tcp(raw_info, payload, payloadlen);
                   ^
network.cpp:1717:22: note: Dereferencing argument payload that is null
    memcpy(tcp_data, payload, payloadlen);
                     ^
2023-10-08 11:37:35 +08:00

View File

@ -1714,6 +1714,7 @@ int send_raw_tcp(raw_info_t &raw_info, const char *payload, int payloadlen) { /
char *tcp_data = send_raw_tcp_buf + +tcph->doff * 4;
if (payload)
memcpy(tcp_data, payload, payloadlen);
int tcp_totlen = tcph->doff * 4 + payloadlen;